Re: EDITOR with tilde not expanded in git-commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, August 28, 2007 at 16:52:58 (+0200) Mike Hommey writes:
>On Tue, Aug 28, 2007 at 09:12:07AM -0500, Bill Lear <rael@xxxxxxxxxx> wrote:
>> My co-worker is visually impaired, and he uses a custom emacs.  His
>> EDITOR is set to something like "~/bin/xemacs -nw".  When git-commit
>> runs, it complains:
>> 
>> % git-commit
>> git-commit: line 582: ~/bin/xemacs -nw: No such file or directory
>> 
>> So, I fiddled with the following line in git-commit:
>> 
>>         ${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"
>
>I don't see how this line could trigger an error like the one you get.
>
>Your error message doesn't tell you it doesn't expand the tilde, it tells
>you it uses the whole string ! It is looking for a "xemacs -nw" file under
>$HOME/bin, which obviously doesn't exist.

Yes, obviously.

>Now, theorically, this should not happen unless you quote the whole
>variable substitution thing.

As I said, EDITOR is set to "~/bin/xemacs -nw", that is, he did
something like this:

% EDITOR="~/bin/xemacs -nw"

>What is your co-worker's shell ?

zsh, but I use bash and it failed for me as well.


Bill
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux