From: Torsten Bögershausen <tboegi@xxxxxx>
The "prefix" was precomposed for MacOs in commit 5c327502db,
MacOS: precompose_argv_prefix()
However, this commit forgot to update "startup_info->prefix" after
precomposing.
Re-arrange the code in setup.c:
Move the (possible) precomposition towards the end of
setup_git_directory_gently(), so that precompose_string_if_needed()
can use git_config_get_bool("core.precomposeunicode") correctly.
Keep prefix, startup_info->prefix and GIT_PREFIX_ENVIRONMENT all in sync.
And as a result, the prefix no longer needs to be precomposed in git.c
Reported-by: Dmitry Torilov <d.torilov@xxxxxxxxx>
Helped-by: Junio C Hamano <gitster@xxxxxxxxx>
Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
---
This part did never made it to the list - it should have gone only
to tboegi@xxxxxx
git send-email decided to cc to the "Helped-by" and "Reported-by" addresses,
a feature that I was not aware of - and can be turned off with --suppress-cc=all
In other words, I typically send these emails only to my self first, re-read
with fresh eyes, and then send them out. End of of blabla.
Changes since V1:
Add a comment in setup.c, to make more clear that git_config_get_bool()
is called, and the setup_XXX() must have prepared everything needed.
git.c | 2 +-
setup.c | 14 ++++++++++----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/git.c b/git.c
index 9bc077a025..b53e665671 100644
--- a/git.c
+++ b/git.c
@@ -423,7 +423,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
int nongit_ok;
prefix = setup_git_directory_gently(&nongit_ok);
}
- prefix = precompose_argv_prefix(argc, argv, prefix);
+ precompose_argv_prefix(argc, argv, NULL);
if (use_pager == -1 && p->option & (RUN_SETUP | RUN_SETUP_GENTLY) &&
!(p->option & DELAY_PAGER_CONFIG))
use_pager = check_pager_config(p->cmd);
diff --git a/setup.c b/setup.c
index c04cd25a30..dcc9c41a85 100644
--- a/setup.c
+++ b/setup.c
@@ -1281,10 +1281,6 @@ const char *setup_git_directory_gently(int *nongit_ok)
} else {
startup_info->have_repository = 1;
startup_info->prefix = prefix;
- if (prefix)
- setenv(GIT_PREFIX_ENVIRONMENT, prefix, 1);
- else
- setenv(GIT_PREFIX_ENVIRONMENT, "", 1);
}
/*
@@ -1311,6 +1307,16 @@ const char *setup_git_directory_gently(int *nongit_ok)
if (startup_info->have_repository)
repo_set_hash_algo(the_repository, repo_fmt.hash_algo);
}
+ /* Keep prefix, startup_info->prefix and GIT_PREFIX_ENVIRONMENT in sync */
+ prefix = startup_info->prefix;
+ if (prefix) {
+ /* This calls git_config_get_bool() under the hood (MacOs only) */
+ prefix = precompose_string_if_needed(prefix);
+ startup_info->prefix = prefix;
+ setenv(GIT_PREFIX_ENVIRONMENT, prefix, 1);
+ } else {
+ setenv(GIT_PREFIX_ENVIRONMENT, "", 1);
+ }
strbuf_release(&dir);
strbuf_release(&gitdir);
--
2.30.0.155.g66e871b664
