On Wed, Mar 31, 2021 at 12:05 PM ZheNing Hu via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > In https://lore.kernel.org/git/xmqqv99i4ck2.fsf@gitster.g/ Junio and > Christian talked about the problem of using strbuf_replace() to replace > $ARG. It's better to sum up a bit the discussions. It's nice to provide a link to the discussions though. > Now pass trailer value as $1 to the trailer command with another > trailer.<token>.cmd config. If this patch series introduces a new trailer.<token>.cmd config option, then I would expect one of the patch in the series to have a subject like "trailer: add new trailer.<token>.cmd config option". > ZheNing Hu (2): > [GSOC] run-command: add shell_no_implicit_args option > [GSOC]trailer: pass arg as positional parameter I guess the "trailer: pass arg as positional parameter" is the one introducing the new trailer.<token>.cmd config option. Also it seems strange that there is no space between "[GSOC]" and "trailer".
