From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Before we iterate over all cache entries, ensure that the index is not sparse. This loop in checkout_all() might be safe to iterate over a sparse index, but let's put this protection here until it can be carefully tested. Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> --- builtin/checkout-index.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/checkout-index.c b/builtin/checkout-index.c index 023e49e271c2..2c2936a9dae0 100644 --- a/builtin/checkout-index.c +++ b/builtin/checkout-index.c @@ -119,6 +119,8 @@ static void checkout_all(const char *prefix, int prefix_length) int i, errs = 0; struct cache_entry *last_ce = NULL; + /* TODO: audit for interaction with sparse-index. */ + ensure_full_index(&the_index); for (i = 0; i < active_nr ; i++) { struct cache_entry *ce = active_cache[i]; if (ce_stage(ce) != checkout_stage -- gitgitgadget