> > - 7 is way too long for warning against something like ":!(glob)", > > no? > > GRRRRR C :-p > (I'll push the changes on the next iteration; including the `like glob` > removed, and whatever comes from our discussion.) Actually ... C does not have a problem with it: root@94ae60990b85:/usr/src/git/t# ../git log -- ':!(glob)' hint: ':!(glob)...': cannot mix shortform magic with longform [e.g. like :(glob)]. hint: If '(glob)...' is a valid path, explicitly terminate magic parsing with ':'; or hint: Disable this message with "git config advice.mixedShortLongMagicPathspec false" commit 14b8580dde326a0bbf9abacac7e09dbe4c38c25e (HEAD -> fix/mixed-short-long-magic) True, it does not look nice; theoretically, any number (even 1!) could be too much to contain ellipsis after that text. Given the size of the change, I would want to say that it is acceptable to leave this as-is. Unless you'd like me to write a generic truncate_at_chars(char *text, int width, char *ellipsis_char_or_default) function.
