On Mon, Mar 29, 2021 at 05:34:21PM -0400, Taylor Blau wrote: > > Did we record any numbers to show the improvement here? I don't think it > > can be demonstrated with this series (since most of the code is dead), > > but I recall that this was motivated by a noticeable slowdown. > > Looking through our messages, you wrote that this seemed to produce a > .8 second speed-up on a large-ish repository that we were testing. > That's not significant overall, the fact that we were spending so long > probably caught our attention when looking at a profiler. That sounds about right from my recollection. > I could go either way on mentioning it. It does feel a little like > cheating to say, "well, if you applied these other patches it would make > it about this much faster". So I'm mostly happy to just keep it vague > and say that it makes things a little faster, unless you feel strongly > otherwise. No, I don't feel strongly. I just wanted to give people reading a sense of what to expect. Now we have. -Peff
