Hi, On Mon, 27 Aug 2007, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > how about this on top (or squashed): > > Looks good. On top of these two... > > An earlier commit 6acbcb92 unfortunately defined --bare as a > synonym to "export GIT_DIR=`pwd`", but I have to say that this > was done without much thinking. Hehe. That was me, I guess... > [...] when the user already had GIT_DIR pointing elsewhere, > iow: > > $ GIT_DIR=/some/where/foo.git git --bare command > > or (worse yet) > > $ git --git-dir=/some/where/foo.git --bare command > > I think it should just keep using the existing value from the > enviroment, instead of overriding. Or it should conflict (which would be an uglier fix, I agree). > *W*A*R*N*I*N*G* > > This _CHANGES_ semantics, so it has a great risk of breaking > people's scripts. However, I have a suspicion that nobody > relied on the insane behaviour. Let's hope that your suspicion holds better than my worktree/gitdir suspicion... In any case, ACK on your patch. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
