Re: [PATCH 4/5] fsck: improve the error on invalid object types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 4/5] fsck: improve the error on invalid object types
From: Johannes Sixt <j6t@xxxxxxxx>
Date: Sun, 28 Mar 2021 10:56:24 +0200
Cc: git@xxxxxxxxxxxxxxx, Junio C Hamano <gitster@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>
In-reply-to: <patch-4.6-d23fb5cd039-20210328T025618Z-avarab@gmail.com>
References: <patch-4.5-515d146cac8-20210328T022343Z-avarab@gmail.com> <cover-0.6-00000000000-20210328T025618Z-avarab@gmail.com> <patch-4.6-d23fb5cd039-20210328T025618Z-avarab@gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

A note on the subject line: we are all pretty sure that you want to
improve the code, not disimprove it. Therefore, the word "improve"
carries not meaning and only takes away space that could be used better.
Perhaps

   fsck: report invalid types recorded in objects

or something. Ditto for 5/5.

-- Hannes

References:
- [PATCH 4/4] usage.c: add a non-fatal bug() function to go with BUG()
  - From: Ævar Arnfjörð Bjarmason
- [PATCH 0/5] fsck: improve error reporting
  - From: Ævar Arnfjörð Bjarmason
- [PATCH 4/5] fsck: improve the error on invalid object types
  - From: Ævar Arnfjörð Bjarmason

Prev by Date: Re: [PATCH v2] csum-file: make hashwrite() more readable
Next by Date: Re: [PATCH 6/7] object tests: add test for unexpected objects in tags
Previous by thread: [PATCH 4/5] fsck: improve the error on invalid object types
Next by thread: [PATCH 3/5] fsck: don't hard die on invalid object types
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux