Re: [PATCH 4/5] doc lint: fix bugs in, simplify and improve lint script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Fri, Mar 26, 2021 at 11:36:49AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>>  lint-docs::
>> -	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl
>> +	$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl \
>> +		--section=1 $(MAN1_TXT) \
>> +		--section=5 $(MAN5_TXT) \
>> +		--section=7 $(MAN7_TXT)	\
>> +		--to-lint $(ALL_TXT)
>
> This is probably bikeshedding, but I would have expected the invocation
> to be:
>
>   link-gitlink.perl \
>     $(HOWTO_TXT) $(INCLUDE_TARGETS_TXT) \
>     --section=1 $(MAN1_TXT) \
>     --section=5 $(MAN5_TXT) \
>     --section=7 $(MAN7_TXT)
>
> I.e., list each filename only once, with the previous --section giving
> the expected section (and if before any --section, then expect no
> section).

Makes more sense than the presented patch.  Optionally "--section="
could be used to cancel the section that was previously given.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux