Re: [PATCH v4 00/10] userdiff: refactor + test improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 24, 2021 at 12:02:54PM -0700, Junio C Hamano wrote:

> Johannes Sixt <j6t@xxxxxxxx> writes:
> 
> > Am 24.03.21 um 02:48 schrieb Ævar Arnfjörð Bjarmason:
> >> This is a restart of the 35-patch v3 of this topic at
> >> https://lore.kernel.org/git/20210224195129.4004-1-avarab@xxxxxxxxx/
> >> 
> >> I still plan on submitting the rest of it, but wanted to start with
> >> the early parts of that series that hasn't been controversial or has
> >> outstanding feedback I haven't addressed.
> >> 
> >> The range-diff to v3 is just for those patches I'm re-rolling here.
> >
> > I'm mostly relying on the interdiff below. I think I had no comments on
> > these patches in the earlier round, so:
> >
> > Acked-by: Johannes Sixt <j6t@xxxxxxxx>
> 
> Thanks.  I've read through everything in the patch this round,
> ignoring anything that came before, and them looked mostly fine.
> Peff's comment on 01/10 to make it if/else if cascade does make
> sense to me, too, though.

I left some other comments on patch 4, mostly about clarity. But just to
be clear, I don't think there's anything incorrect there, and I wouldn't
be offended if it gets picked up as-is.

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux