Re: git-import.sh using git-fast-import

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote:
> On 8/28/07, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> > Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote:
> > > It is not really good. It does not run as fast as git-add &&
> > > git-commit.
> >
> > This would be much faster if it was in Perl/Python/Tcl...
> 
> Yes. I was tempted to rewrite it in C but too lazy.

I'm not sure this really warrants C.  Just a language that is able
to do lots of file IO, avoids forks to do it, and is also simple
enough that most readers could follow it.  Your shell script fits
all byt the "avoids forks" part.  Anyone who seriously needs the
speed can probably rewrite it based upon your short script.
 
> > > But it can swallow big directories that git-add &&
> > > git-commit can't.
> >
> > I'm curious, what do you mean by being able to swallow big
> > directories that git-add/git-commit cannot?  Those tools should
> > not be choking on large directories.  What behavior are you seeing
> > that caused you to decide these tools weren't able to handle a
> > big directory?
> 
> I imported a ~1gb directory (including all subdirectories). I don't
> remember git-add or git-commit that died. It ate all my memory, froze
> my computer and I had to hard reset the box.

Uhhh.  That's not very good.

  How many files?
  What was their average size?
  What was the size of the largest file?
  Binary?
  Text?

We should be able to handle this.  The fact that it killed your
system means we should look at that and fix it.

-- 
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux