Re: [PATCH v13] [GSOC] commit: add --trailer option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 22, 2021 at 11:23 AM ZheNing Hu <adlternative@xxxxxxxxx> wrote:

> 2.
> `git interpret-trailers --in-place`  seem like work on git top-dir,
> If I am in a sub-dir `b` and I want to change a file such as `d.c`,
> then I must use `git interpret-trailers --in-place b/d.c` to add some
> trailers.

What happens without --in-place? Are the input files read correctly?

> I think the original intention of `--in-place` is to modify a file similar to
> "$COMMIT_MSG_FILE", so make it run at top-dir, but this is not reflected
> in the git documentation. This at least confuses people who use this
> option for the first time. Is it worth modifying? Or is there something
> wrong with the design of `--in-place`?

I haven't checked but there is perhaps a bug in
create_in_place_tempfile() in "trailer.c".



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux