On Mon, Mar 22, 2021 at 2:26 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > I'm working on some extensions to Gerrit for which it would be very > > beneficial if we could tell from the reflog if an update is a > > fast-forward or not: if we find a SHA1 in the reflog, and see there > > were only FF updates since, we can be sure that the SHA1 is reachable > > from the branch, without having to open packfiles and decode commits. > > > > For the reftable format, I think we could store this easily by > > introducing more record types. [snip]. > > Aside from what others have mentioned here, you're talking about the > log_type field are you not? I.e.: > https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md#log-block-format Correct. > Has that "log_type = 0x0" tombstone proven to be a worthwhile > optimization past the stash case mention there (which is presumably not > relevant to the vast majority of Google's use-cases). I've never really understood the log_type=0x0 use case. I think it was added solely to cater for a use case in CGit's stash command. > I.e. it's redundant to looking at the record and seeing if new_id = > ZERO_OID. > > Similarly can't ff v.s. non-ff be deduced unambiguously by looking ahead > to the next record, and seeing if the current record's "old_id" matches > that of the last record's "new_id". If it does it's a FF, if not it's a > non-FF (or a create/delete). I don't see how that will tell you FF vs non-FF-ness. Both an FF update and a non-FF update look like 'new_oid = 20-random-bytes'. Barring further info, you have to lookup the commit object for those bytes, and then walk back to see if you pass old_oid. AFAICT, a correct sequence of ref updates (FF or not) always has prev.new_oid = current.old_oid. > > [Ævar: snipped from earlier] Today we have 0 = deletion, 1 = update, > > and we could add 2 = FF update, 3 = non-FF update. > > I've written log table implementations (a site table in a RDBMS) for git > (one table for refs) which had: > > create, ff, non-ff, delete > > I wonder if that quad-state would be useful for reftable too, with this > proposed change you'd still need to unpack the record and see if the > old_id is ZERO_OID to check if it's a creation, would you not? Delete & create are handled with ZERO_OID. The reftable format makes it so that you have to decode a record in order to read past it (there is no size framing the table entry level), so there is no big performance advantage in encoding this information in the log_type. You merely use a log_type bit rather than a 20 byte raw ID. Since log records are zlib compressed anyway, it probably also makes no space difference. > I also wonder if it couldn't be: > > 0 = deletion, 1 = non-ff-update, 2 = ff-update, 4 = creation > > So the format wouldn't forever carry the historical wart of this not > having been considered from the beginning. If you do it like this, you will force that all implementations to have to compute whether a (forced) update is a FF or not. I don't know if that is a problem. A 'maybe non-FF' value would be useful. Perhaps we could even do simply 0 = deletion, 1 = maybe-ff-update, 2 = guaranteed-ff-update > It would mean that the few current reftable users (just Google?) would > have to look at the record to see if it's *really* a non-ff-update, but > presumably they need to do so now for ff v.s. non-ff, so they're no > worse off than they are now. At Google, we currently don't record log records in reftable yet. From our perspective, we could probably change the standard 'in place'. JGit has supported reftable since Nov 2019, but I'm unaware of users; I did hear about GerritForge wanting to try it out in production this year. > Then when those users know they're on a version that distinguishes these > they can hard rely on 1 not being a "ff for sure", not a "maybe" status > for new updates. Presumably they either don't care about ancient reflog > records, or a one-off migration of rewriting the records for older > entries could be done. > > Also between my [1] and this proposal we have at least a reftable v1.01 > in the wild (the filename locking behavior change discussed in [1]), and > this would make it v1.02, but the only up-to-date spec is for v1.00 (and > maybe JGit has other changes I haven't tracked). The file locking update has been added to the standard, https://github.com/git/git/pull/951. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
