On 3/17/2021 11:30 AM, Johannes Schindelin via GitGitGadget wrote: > While dog-fooding Jeff Hostetler's FSMonitor patches, I ran into a really > obscure segmentation fault during one of my epic Git for Windows rebases. Thanks for dogfooding! > Turns out that this bug is quite old. A little over a year, yes, since the v2 hook was committed. It's old enough that these could be applied to 'maint'. > Johannes Schindelin (2): > fsmonitor: fix memory corruption in some corner cases > fsmonitor: do not forget to release the token in `discard_index()` The patches themselves are correct and describe the problem well. They only show up during non-trivial uses of FS Monitor and index updates, so I understand your hesitance to write tests that trigger these problems. Thanks, -Stolee
