Hi Taylor,
On Tue, Mar 16, 2021 at 09:52:47AM -0400, Taylor Blau wrote:
> Hi,
>
> Is it possible that your bisection script doesn't report success
> properly? Bisecting the same range (v2.30.0..v2.31.0) with
>
> $ cat run.sh
> #!/bin/sh
> false
>
> does say that my 3b1ca60f8f (ewah/ewah_bitmap.c: avoid open-coding
> ALLOC_GROW(), 2020-12-08) is the first bad commit.
You are spot on. It was a busy day and I only had a few minutes to
look at our internal pipeline of the test suite. I guess I was doing
something along the line of.
$ git bisect start HEAD v2.30.0
$ git bisect run 'cd t && GIT_TEST_PROTOCOL_VERSION=1 ./t5606-clone-options.sh'
Which does indeed errored out and pointed to your commit.
>
> Thanks,
> Taylor
I have properly re-run the bisection in a './test.sh' bash script and
here are the suspicious commits:
1. For t7810 and t5300 failing when GIT_TEST_FAIL_PREREQS=1:
a926c4b904bdc339568c2898af955cdc61b31542 is the first bad commit
commit a926c4b904bdc339568c2898af955cdc61b31542
Author: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
Date: Thu Feb 11 02:53:51 2021 +0100
tests: remove most uses of C_LOCALE_OUTPUT
As a follow-up to d162b25f956 (tests: remove support for
GIT_TEST_GETTEXT_POISON, 2021-01-20) remove those uses of the now
always true C_LOCALE_OUTPUT prerequisite from those tests which
declare it as an argument to test_expect_{success,failure}.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
2. For failing t5606 while 'GIT_TEST_PROTOCOL_VERSION=1' was used:
4f37d45706514a4b3d0259d26f719678a0cf3521 is the first bad commit
commit 4f37d45706514a4b3d0259d26f719678a0cf3521
Author: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
Date: Fri Feb 5 12:48:49 2021 -0800
clone: respect remote unborn HEAD
Teach Git to use the "unborn" feature introduced in a previous patch as
follows: Git will always send the "unborn" argument if it is supported
by the server. During "git clone", if cloning an empty repository, Git
will use the new information to determine the local branch to create. In
all other cases, Git will ignore it.
Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
Documentation/config/init.txt | 2 +-
builtin/clone.c | 16 ++++++++++++++--
connect.c | 28 ++++++++++++++++++++++++++--
t/t5606-clone-options.sh | 8 +++++---
t/t5702-protocol-v2.sh | 25 +++++++++++++++++++++++++
transport.h | 8 ++++++++
6 files changed, 79 insertions(+), 8 deletions(-)
Thanks,
Son Luong.
