On Mon, Mar 15, 2021 at 4:44 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > A v3 of a refactoring of tree.c. See v2 at > https://lore.kernel.org/git/20210308022138.28166-1-avarab@xxxxxxxxx/ > > This brings back pretty much the old read_tree_recursive() under the > name read_tree_at() as suggested in > https://lore.kernel.org/git/xmqqft106sok.fsf@gitster.g/ Patch 8/9 was a bit harder for me to read; I'm not sure if that means the patch needs improvement or just reflects a personal failing. :-) But ultimately, it's minor and the rest of the series looks good. With or without a few tweaks to that patch: Reviewed-by: Elijah Newren <newren@xxxxxxxxx>
