On Mon, Mar 15, 2021 at 6:01 PM Nipunn Koorapati <nipunn1313@xxxxxxxxx> wrote: > > Unusual 4-space indentation rather than typical 1-tab. > > Thanks for identifying - will fix in the next patch series. Perhaps in > a separate patch we could add a unit test that validates the codebase > for such style? My guess is that a test which complains about existing style violations would not be particularly helpful since it's output likely would be noisy due to existing style violations. (For the same reason, we wouldn't want to complain about style violations in tests either since existing test scripts are full of violations.) What is more interesting than identifying existing violations is identifying violations before they make it into the codebase. For instance, you could run your patches through `checkpatch.pl`[1] before submitting them. [1]: https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl
