On 3/11/2021 12:04 PM, Taylor Blau wrote: > Here is another reroll of my series to implement a reverse index in > preparation for multi-pack reachability bitmaps. The previous version > was based on 'ds/chunked-file-api', but that topic has since been merged > to 'master'. This series is now built directly on top of 'master'. > > Not much has changed since last time. Jonathan Tan reviewed the previous > version, and I incorporated feedback from his review: > > - The usage macros in builtin/multi-pack-index.c were pulled out and > defined separately. > - Some sloppiness with converting a signed index referring to the > preferred pack into an unsigned value was cleaned up. > - Documentation clean-up, particularly in patches 12 and 13. > > There are a couple of new things that we found while testing this out at > GitHub. > > - We now call finalize_object_file() on the multi-pack reverse index > to set the correct permissions. > - Patch 14 removed a stray hunk that introduced a memory leak. > - Patch 16 (courtesy of Peff) is new. It improves the cache locality > of midx_pack_order_cmp(), which has a substantial impact on > repositories with many objects. > > Thanks in advance for your review. I've reviewed the changes since my last review and this one looks good, including that new patch from Peff. Thanks, -Stolee
