On Thu, 11 Mar 2021 at 13:36, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > [...] > Thanks for re-rolling. I left some relatively minor comments on patch > [2/6] and some substantial documentation-related comments on [6/6]. > (If you take my suggested documentation rewrites verbatim, you can > have my Signed-off-by: along with them.) > Sure, I will add the Signed-off-by. Thanks for all the suggestions, I will fix them and update in the next version. > One final request: Please consider using the --range-diff or > --interdiff options or both when preparing your series with > git-format-patch. Doing so can really help reviewers focus on the > changes made from re-roll to re-roll without having to painstakingly > re-read each patch in the series -- even if a patch didn't change -- > thus saving time. Okay, I will add it next time. Thanks and Regards, Charvi
