Dan Moseley <Dan.Moseley@xxxxxxxxxxxxx> writes: > Thank you Thorsten. This makes sense to me. Do you want to add a test? > I believe this is what I had in my original patch, that worked pretty well: Would this succeed unconditionally on all platforms, or only relevant on case-insensitive filesystems? Lack of any prerequisite on a new test is a good thing (if it is correct), but the description of the change talked about case insensitivity, so ... > diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh > index 63d5f41a12..5c7fee9bd8 100755 > --- a/t/t7001-mv.sh > +++ b/t/t7001-mv.sh > @@ -152,6 +152,14 @@ test_expect_success \ > 'move into "."' \ > 'git mv path1/path2/ .' > > +test_expect_success \ > + 'fail to move file already in index under different cased name' \ > + 'echo 1 > foo && > + git add foo && > + git commit -m add_file -- foo && > + git mv foo FOO && > + test_expect_code 128 git mv foo BAR' > + > test_expect_success "Michael Cassar's test case" ' > rm -fr .git papers partA && > git init &&