On Fri, 26 Feb 2021 at 17:24, Matheus Tavares <matheus.bernardino@xxxxxx> wrote: > This assertion is not really necessary, as the apply_filter() call below > it already performs the same check. And when this condition is not met, > - assert(ca.drv->clean || ca.drv->process); FWIW, this LGTM. > + test_i18ngrep "fatal: test.ac: clean filter .absentclean. failed" stderr > + test_i18ngrep "fatal: test.as: smudge filter absentsmudge failed" stderr (Funny how these two error messages differ in quoting. That's obviously not anything your patch needs to fix.) Martin