On Fri, Feb 26, 2021 at 8:34 AM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 2/25/2021 8:58 PM, Elijah Newren via GitGitGadget wrote: > > This series depends on en/diffcore-rename (a concatenation of what I was > > calling ort-perf-batch-6 and ort-perf-batch-7). > > > > Changes since v2: > > > > * Rearrange the patches in the series to have a top-down ordering rather > > than bottom-up -- as suggested by Stolee, Ævar, and Junio > > * Several comments and style improvements suggested by Stolee > > * Replace xstrfmt() with a few strbuf_add*() calls, as suggested by Stolee Oh, and I also forgot to mention that I applied Ævar's suggested cleanup -- return-in-if-block-to-avoid-indented-else. > I like the new layout. The code looks good. The only nit I have is that > some of the old commit messages read awkwardly with the new ordering. Doh, I fixed some of those up, but apparently missed some. I'll clean those up too. > These are not critical, so this version gets my: > > Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Thanks, I'll include that in my reroll with the cleaned up commit messages.
