Re: [PATCH v2 04/10] diffcore-rename: extend cleanup_dir_rename_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 04/10] diffcore-rename: extend cleanup_dir_rename_info()
From: Derrick Stolee <stolee@xxxxxxxxx>
Date: Wed, 24 Feb 2021 10:37:02 -0500
Cc: Elijah Newren <newren@xxxxxxxxx>
In-reply-to: <f7bdad78219de6819d0403f8957e9a0c8b4218bc.1614123848.git.gitgitgadget@gmail.com>
References: <pull.844.git.1613289544.gitgitgadget@gmail.com> <pull.844.v2.git.1614123848.gitgitgadget@gmail.com> <f7bdad78219de6819d0403f8957e9a0c8b4218bc.1614123848.git.gitgitgadget@gmail.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Thunderbird/86.0

On 2/23/2021 6:44 PM, Elijah Newren via GitGitGadget wrote:
> +		for (i=0; i<to_remove.nr; ++i)

nit: "i < to_remove.nr"

I'm really stretching to find something valuable to say about
these well-constructed patches.

-Stolee

References:
- [PATCH 00/10] Optimization batch 8: use file basenames even more
  - From: Elijah Newren via GitGitGadget
- [PATCH v2 00/10] Optimization batch 8: use file basenames even more
  - From: Elijah Newren via GitGitGadget
- [PATCH v2 04/10] diffcore-rename: extend cleanup_dir_rename_info()
  - From: Elijah Newren via GitGitGadget

Prev by Date: Re: [PATCH v2 6/7] add: warn when pathspec only matches SKIP_WORKTREE entries
Next by Date: Re: [PATCH v2 05/10] diffcore-rename: compute dir_rename_counts in stages
Previous by thread: [PATCH v2 04/10] diffcore-rename: extend cleanup_dir_rename_info()
Next by thread: Re: [PATCH v2 04/10] diffcore-rename: extend cleanup_dir_rename_info()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux