Denton Liu <liu.denton@xxxxxxxxx> writes: > I don't think this test is quite necessary. In other parts of the > code, we've already tested that local configs have priority over > global configs. We can assume that config machinery works so we > don't need to test it here. I am not so sure if we should place so much trust in the code of "rebase", or any other subsystem for that matter, that it uses the configuration API and parse-options API correctly. The do_test_rebase helper introduced here would be useful clean-up on its own, so I'd rather take it as-is.