[cc:+æver] On Thu, Feb 18, 2021 at 7:22 AM Rasmus Villemoes <rv@xxxxxxxxxxxxxxxxxx> wrote: > Commit d5cfd142ec (tests: teach the test-tool to generate NUL bytes > and use it) changed the implementation of this helper, but didn't > preserve the magic meaning of the word 'infinity' - in fact, since > strtol() returns 0 when presented with that string, it ends up > producing no output at all. Instead, the C implementation interprets > lack of optional argument to mean infinity. > > Since the last and only user that actually passed 'infinity' vanished > with d99194822b (Revert "t5562: replace /dev/zero with a pipe from > generate_zero_bytes"), just update the comment to match the > implementation, and while there, short-circuit "forever or X" to just > X. Makes sense, but note that generate_zero_bytes() is going away entirely[1], and that the patch series which removes it is likely to be merged to "master" soon[2]. [1]: https://lore.kernel.org/git/20210212132942.17325-5-avarab@xxxxxxxxx/ [2]: https://lore.kernel.org/git/xmqqr1legm5v.fsf@gitster.g/
