Thanks Taylor, Derrick and Junio for reviewing v1. I've updated the
patch's message to include one of the performance reports that was
previously only on the cover-letter as suggested.
Rafael Silva (1):
blame: remove unnecessary use of get_commit_info()
builtin/blame.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
Range-diff against v1:
1: e0c698370e ! 1: 4d70ce9545 blame: remove unnecessary use of get_commit_info()
@@ Commit message
structure and remove the internal call to get_commit_info() thus
cleaning up and optimizing the code path.
+ Enabling Git's trace2 API in order to record the execution time for
+ every call to determine_line_heat() function:
+
+ + trace2_region_enter("blame", "determine_line_heat", the_repository);
+ determine_line_heat(ent, &default_color);
+ + trace2_region_enter("blame", "determine_line_heat", the_repository);
+
+ Then, running `git blame` for "kernel/fork.c" in linux.git and summing
+ all the execution time for every call (around 1.3k calls) resulted in
+ 2.6x faster execution (best out 3):
+
+ git built from 328c109303 (The eighth batch, 2021-02-12) = 42ms
+ git built from 328c109303 + this change = 16ms
+
Signed-off-by: Rafael Silva <rafaeloliveira.cs@xxxxxxxxx>
## builtin/blame.c ##
--
2.30.1.850.g2d41e9e789
