On Tue, Feb 16, 2021 at 06:58:16PM -0500, Jeff King wrote: > For showing the impact of the optimizations in patches 7 and 8, I think > doing a full repack with --honor-pack-keep is a better test. Because > then we're always doing a full traversal, and most of the work continues > to scale with the repo size (though obviously not the actual shuffling > of packed bytes around). That would get rid of the weird "no work to do" > case in the single-pack tests, too. I meant to add: but I do like that we are timing --stdin-packs, too. We may actually want to time both. Another thing we _could_ do, if we have --honor-pack-keep perf tests, is to shuffle patches 5, 6, and 7 towards the front of the series. They should be able to show off the improvement even without the --stdin-packs feature. -Peff
