On 2021-02-16, Junio C Hamano wrote: > Jan “Khardix” Staněk <khardix@xxxxxxxxx> writes: > > This introduces a special case just for handling $smtp_server… > > Yes, and that was very much deliberate, as I think > > git send-email --smtp-server=~/bin/my-phoney-sendmail > > won't be affected by %config_path_settings. $smtp_ssl_cert_path has > the same problem already, and I didn't want to make things worse (I > think %config_path_settings is a mistake---it is fine to have a list > of variables that can use ~tilde expansion, but I do not see why it > makes sense to allow the ~tilde expansion when the value came from > configureation files, and not from the command line). Well, unless I'm missing something, shouldn't the tilde above be expanded by the shell before actually being passed as argument? $ echo simulate --smtp-server=~/bin/my-phoney-sendmail simulate --smtp-server=/home/khardix/bin/my-phoney-sendmail I assumed that only the config values are handled specially because only they need that – the CLI is handled by shell in advance. Never played with $smtp_ssl_cert_path though, so if there are known problems, just ignore me – or better, point me to the relevant issue/discussion, if you can be bothered :) Thanks. > > My concern was that if there is a SMTP server actually named > > i.e. `~someone.example.org`, this change would break that. > > Can tilde appear in a valid DNS name? I doubt it. So I actually did my homework and skimmed through the relevant RFCs (RFC952 and RFC1123); as it turns out, no, it cannot – only ASCII alphanumerics, '-' and '.' are valid characters. -- Jan Staněk – Khardix
Attachment:
signature.asc
Description: PGP signature
