Re: [PATCH v2 00/27] userdiff: refactor + test + doc + misc improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 15.02.21 um 16:44 schrieb Ævar Arnfjörð Bjarmason:
Incorporates all the feedback on v2 and more, see the range-diff
below.

I've read through all patches and left a few comments.

My main critique is that the new way to specify test cases is not an improvement because the code is hard to parse. The desire to improve test precision moves the balance too far away from the simplicity to add new test cases, IMO.

I appreciate the new test cases for ADA and Ruby as well as the discovery and fixes of the many small deficiencies.

-- Hannes



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux