Thank You Eric and Junio. Sorry I forget about spelling. Okay I will correct it and send a new patch series today. Thank You! On Thu, Feb 11, 2021 at 1:07 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > > > On Tue, Feb 9, 2021 at 6:13 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> shubham verma <shubhunic@xxxxxxxxx> writes: > >> > In this patch series modernize the t7001 test script by changing the > >> > style of its tests from an old one to the modern one and by cleaning > >> > up the test script. > >> > > >> I would have used test_write_lines instead of here-doc in 9/10, but > >> that is such a minor preference thing that it is not worth going > >> back and replace. Nothing else stood out during my cursory scan. > > > > I read over the entire series and likewise didn't find anything to > > comment on, thus consider it in good shape. For what it's worth, > > consider this series: > > > > Reviewed-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > > Yup, this one looked good to me. Thanks. > > Except that the author's name were spelled in all lowercase, unlike > v1, which made me wonder if it was intentional, that is.
