On 2/10/21 6:02 PM, Taylor Blau wrote: > + unsigned char midx_hash[GIT_MAX_RAWSZ]; I was initially thinking we should use something like 'struct object_id' here, but the hash we are storing doesn't correspond to an object, which would be confusing. I suppose this is the most correct thing to do. > - finalize_hashfile(f, NULL, CSUM_FSYNC | CSUM_HASH_IN_STREAM); > + finalize_hashfile(f, midx_hash, CSUM_FSYNC | CSUM_HASH_IN_STREAM); And this is of course correct. The issue will be what happens to 'midx_hash' in the later changes. Will keep reading. Thanks, -Stolee
