On Tue, Feb 9, 2021 at 6:27 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Matheus Tavares <matheus.bernardino@xxxxxx> writes: > > > The variables `path` and `ce->name`, at write_entry(), usually have the > > same contents, but that's not the case when using a checkout prefix or > > writing to a tempfile. (In fact, `path` will be either empty or dirty > > when writing to a tempfile.) Therefore, these variables cannot be used > > interchangeably. In this sense, fix wrong uses of `path` in error > > messages where it should really be `ce->name`. (There doesn't seem to be > > any misuse in the other way around.) > > Sounds reasonable. Don't we want to protect this fix with tests? Yeah, good idea. I will add a couple tests to check the error message on missing blobs and when trying to write a submodule to a tempfile. This should cover 3 out of the 4 error() calls changed in this patch. (The last one would be when ce->mode is unknown. I'm not sure if/how I can trigger that case.)
