Various miscellaneous small and easy to review cleanups & fixes to the test libraries. This doesn't conflict with the current "seen" branch. Ævar Arnfjörð Bjarmason (12): test-lib: remove check_var_migration test lib: change "error" to "BUG" as appropriate test-lib-functions: move test_set_index_version() to its user test-lib-functions: remove generate_zero_bytes() wrapper test libs: rename bundle helper to "lib-bundle.sh" test libs: rename gitweb-lib.sh to lib-gitweb.sh test-lib-functions: move function to lib-bitmap.sh t/.gitattributes: sort lines test libs: rename "diff-lib" to "lib-diff" test-lib-functions: remove bug-inducing "diagnostics" helper param test-lib-functions: assert correct parameter count test-lib-functions: split out {debug,path,text} helpers t/.gitattributes | 4 +- t/README | 8 +- t/lib-bitmap.sh | 26 ++ t/{test-bundle-functions.sh => lib-bundle.sh} | 0 t/{diff-lib.sh => lib-diff.sh} | 0 t/{diff-lib => lib-diff}/COPYING | 0 t/{diff-lib => lib-diff}/README | 0 t/{gitweb-lib.sh => lib-gitweb.sh} | 0 t/t2104-update-index-skip-worktree.sh | 5 + t/t3404-rebase-interactive.sh | 3 +- t/t4000-diff-format.sh | 2 +- t/t4001-diff-rename.sh | 2 +- t/t4003-diff-rename-1.sh | 6 +- t/t4004-diff-rename-symlink.sh | 2 +- t/t4005-diff-rename-2.sh | 6 +- t/t4007-rename-3.sh | 6 +- t/t4008-diff-break-rewrite.sh | 6 +- t/t4009-diff-rename-4.sh | 6 +- t/t4010-diff-pathspec.sh | 2 +- t/t4011-diff-symlink.sh | 2 +- t/t4013-diff-various.sh | 2 +- t/t4015-diff-whitespace.sh | 2 +- t/t4027-diff-submodule.sh | 2 +- t/t4034-diff-words.sh | 2 +- t/t4038-diff-combined.sh | 2 +- t/t4061-diff-indent.sh | 2 +- t/t4206-log-follow-harder-copies.sh | 2 +- t/t5310-pack-bitmaps.sh | 2 + t/t5318-commit-graph.sh | 2 +- t/t5510-fetch.sh | 2 +- t/t6020-bundle-misc.sh | 2 +- t/t6113-rev-list-bitmap-filters.sh | 1 + t/t6426-merge-skip-unneeded-updates.sh | 16 +- t/t6500-gc.sh | 4 +- t/t7501-commit-basic-functionality.sh | 2 +- t/t9300-fast-import.sh | 2 +- t/t9500-gitweb-standalone-no-errors.sh | 2 +- t/t9501-gitweb-standalone-http-status.sh | 2 +- t/t9502-gitweb-standalone-parse-output.sh | 2 +- t/test-lib-functions.sh | 305 +----------------- t/test-lib-functions/debug.sh | 99 ++++++ t/test-lib-functions/path.sh | 137 ++++++++ t/test-lib-functions/text.sh | 33 ++ t/test-lib.sh | 30 -- 44 files changed, 370 insertions(+), 373 deletions(-) create mode 100644 t/lib-bitmap.sh rename t/{test-bundle-functions.sh => lib-bundle.sh} (100%) rename t/{diff-lib.sh => lib-diff.sh} (100%) rename t/{diff-lib => lib-diff}/COPYING (100%) rename t/{diff-lib => lib-diff}/README (100%) rename t/{gitweb-lib.sh => lib-gitweb.sh} (100%) create mode 100644 t/test-lib-functions/debug.sh create mode 100644 t/test-lib-functions/path.sh create mode 100644 t/test-lib-functions/text.sh -- 2.30.0.284.gd98b1dd5eaa7