Am 02.02.21 um 03:00 schrieb Ævar Arnfjörð Bjarmason: > When git invokes a pager that exits with non-zero the common case is > that we'll already return the correct SIGPIPE failure from git itself, > but the exit code logged in trace2 has always been incorrectly > reported[1]. Fix that and log the correct exit code in the logs. There's a more severe problem here, not with your patch, but with trace2 in general: it invokes async-signal-unsafe functions from a signal handler, in particular, realloc, vsnprintf, gettimeofday, localtime_r (and probably a lot more) via fn_child_exit_fl of trace2/tr2_tgt_normal.c Is that something that we should care about? -- Hannes
