On Wed, Feb 3, 2021 at 7:44 PM Lance Ward <ljward10@xxxxxxxxx> wrote: > On Wed, Feb 3, 2021 at 4:51 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Our log message begins with the description of the current status, > > so "Currently" is not something you need to say. > > I'm disappointed by your tone... > > I'll go ahead and close my pull requests, if someone else wants > to pick them up that's fine with me. It is, unfortunately, easy to misinterpret a reviewer's neutral tone as being negative or as an attempt to shame the author. But be assured that the goal of reviewers on this project is to help the patch author get the submission into proper shape for acceptance, and when Junio takes the time to write such a comprehensive review, he does so because he sees promise in both the patches and in the author of the patches. A review as extensive as this one is intended to get the newcomer up to speed quickly with local project conventions (such as how commit messages are written) and to help land the patches with as few revisions as possible since both submitter and reviewer time is valuable.
