Junio C Hamano <gitster@xxxxxxxxx> writes: >> +void add_chunk(struct chunkfile *cf, >> + uint64_t id, >> + chunk_write_fn fn, >> + size_t size); > > Shouldn't this match the order of members in chunk_info struct? Nah. Unless there are other reasons to touch numerous add_chunk() calls that have already been written (like we find a need to add a new parameter to the call), I do not think this matters too much. Thanks.