Hi Junio, On Sun, 31 Jan 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > On Sun, Jan 31 2021, Junio C Hamano wrote: > > > > > >> * ab/detox-gettext-tests (2021-01-21) 3 commits > >> - tests: remove uses of GIT_TEST_GETTEXT_POISON=false > >> - tests: remove support for GIT_TEST_GETTEXT_POISON > >> - ci: remove GETTEXT_POISON jobs > >> > >> Get rid of "GETTEXT_POISON" support altogether, which may or may > >> not be controversial. > > > > I'm waiting on SZEDER'S feedback on [1], ditto the last What's > > Cooking[2]. Also as noted in [2] the "do we keep GETTEXT_POISON at all" > > question. > > > > How about we just remove it and see if people who love it will come out > > of the woodworks, the patches aren't going to be hard to revert... > > Yeah, why not ;-) I'll give you a reason. We're not really strong on the inclusion front, and translations are one thing that we actually do right on that end. Removing even the scant testing of translated messages that we do have strikes me as the opposite of improving the situation. Sadly, I won't have the time to pursue my GETTEXT_POISON effort further, at least not in the short run, and y'all seem to be bent on making that effort futile anyway. So yeah, why not ;-) Ciao, Dscho
