Hi Christian,
On Sat, Jan 30, 2021 at 3:58 AM Christian Couder
<christian.couder@xxxxxxxxx> wrote:
>
> On Fri, Jan 29, 2021 at 10:15 PM Hariom Verma via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
> >
> > From: Hariom Verma <hariom18599@xxxxxxxxx>
> >
> > As we would like to use this same logic in ref-filter, it's nice to
> > get invalid trailer argument. This will allow us to print precise
> > error message, while using `format_set_trailers_options()` in
> > ref-filter.
>
> Thanks for continuing to work on this!
>
> > {
> > for (;;) {
> > const char *argval;
> > size_t arglen;
> >
> > + if(**arg == ')') {
> > + break;
> > + }
>
> A space char is missing between "if" and "(". Also no need for "{" and
> "}". It could just be:
>
> > + if (**arg == ')')
> > + break;
Thanks for pointing this out. Will fix it.
