On Thu, Jan 28, 2021 at 08:21:50PM -0500, Taylor Blau wrote: > [sane_unset outside of a test] > > I think I probably took this from the trace2 tests? Not sure. I'm glad > that it's not wrong, strictly speaking. > > This is another instance that I'd be happy to send a follow-up patch to > get rid of all of these at once, unless you feel strongly that it should > be changed in this series before applying. Nope, I don't feel strongly. > > This one is making the test a bit looser (it would miss a case where we > > somehow failed to generate the .idx). That seems like an unlikely bug, > > but I wonder if we can keep the original behavior. I guess: > > > > ls .git/objects/pack/*.pack \ > > .git/objects/pack/*.idx | > > sort >post_packs > > > > would work? > > Sure, I see what you're saying. To be honest, I'm skeptical that we'd > have a bug which failed only this one test, so I'm hesitant to send a > replacement/reroll for this alone. > > If you feel strongly, though, I'm happy to change it. (But, I'll err on > the side of leaving it as-is, since you indicated in your response to > v3's cover letter that you'd be OK if I discarded some or all of your > suggestions). Nope, I don't feel strongly. Junio even argued elsewhere that these tests may be better off just looking for pack files (which is looser than what they do now, but as we've said, unlikely to matter for any realistic bug). So I'm happy enough with what you have. -Peff
