On Thu, Jan 28, 2021 at 08:25:30PM -0500, Taylor Blau wrote: > But, getting back to your original comment, I think that I actually > prefer to have the GIT_TEST_XYZ_DIE stuff in the binary than I do > relying on the perf suite to catch stuff like this. > > I understand your concern about the binary size. I guess you could > #ifdef this out and only build it in during the test suite, but then > you're testing a different binary, and so that calls into question the > integrity of the test suite itself, etc. etc. I care less about binary size, and more just that the production binary people use day-to-day has a bunch of weird test-only behaviors baked into it. I guess nobody is likely to trigger this by accident, though, and anybody who can maliciously impact the environment can do a lot worse. So it's not the end of the world to keep. It just offends my sense of cleanliness and simplicity. ;) > So, I guess that's all to say that I while I do find this to be hack-y > and gross, I don't think that it's all that bad when you compare it to > the alternatives. > > As usual, I'm happy to change it if you feel strongly that it should be > changed. I agree the alternatives are pretty lousy. I don't feel strongly enough to complain further. :) -Peff
