Re: [PATCH v4 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

[Christian Couder <christian.couder@xxxxxxxxx>]

On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio <mirucam@xxxxxxxxx> wrote:

> +       while ((strbuf_getline(&line, fp) != EOF) && !res){

It looks like a space char is missing between ")" and "{"...

> +               res = process_replay_line(terms, &line);
> +       }

...but as there is only one line in the {...}, we could just get rid
of the block like this:

       while ((strbuf_getline(&line, fp) != EOF) && !res)
               res = process_replay_line(terms, &line);

Best,
Christian.