On Thu, Jan 28, 2021 at 08:06:11PM -0500, Jeff King wrote: > On Mon, Jan 25, 2021 at 06:37:09PM -0500, Taylor Blau wrote: > > > Here is a third reroll of my series to introduce an on-disk format for the > > reverse index. Since the first series (to introduce a new API) has been merged > > to 'next', this series has been rebased onto 'next', too. > > > > This version is largely unchanged from the previous, with the following > > exceptions: > > Thanks, these all seemed like improvements to me. I hadn't read > carefully through the test patches yet, so I did so now (in addition to > checking out the changes in the earlier patches). Thank you; I appreciate your close review :-). > My comments range between "musings" and "suggestions". I wouldn't be too > torn up if they are all discarded and this applies as-is, but in > aggregate there may be enough to merit one more re-roll. Thanks again. I discarded a fair amount of them, which I hope you don't mind. I think a few of them could be reasonably dealt with outside of this series. Mostly because they have implications on other parts of the codebase. So I'd like to deal with them all at once, but without adding to the scope of this series. I did especially like your final suggestion about the new test in t5325, so I sent a replacement patch that takes that suggestion (as well as the typofix that you pointed out). Unless you have any objections, I think that this is ready to get picked up. > -Peff Thanks, Taylor
