On Thu, Jan 28, 2021 at 7:49 PM Jeff King <peff@xxxxxxxx> wrote: > On Mon, Jan 25, 2021 at 06:37:38PM -0500, Taylor Blau wrote: > > +sane_unset GIT_TEST_WRITE_REV_INDEX > > I think we had a discussion a while ago about sane_unset outside of an > &&-chain, where it does nothing that regular "unset" would not. But I > don't know if we reached any kind of conclusion. I actually argued that > it was fine in: > https://lore.kernel.org/git/20200630185536.GA1888406@xxxxxxxxxxxxxxxxxxxxxxx/ > So I guess I should probably stand by that. ;) I recall that discussion. The fact that sane_unset() outside of a test caused a hiccup in your reading of the patch which led you to dig through the mail archive and spend time writing about it in your review could be interpreted as yet another argument against its use outside of tests (specifically, it wastes reviewer time). Of course, it's such a minor thing, though, not at all worth a re-roll.
