On Thu, Jan 28, 2021 at 01:16:50AM -0500, Jeff King wrote: > Note that "get_sha1_hex()" is a confusing historical name. It is > actually using the_hash_algo, so it would be sha256 in a sha256 repo. > We'll switch to using parse_oid_hex(), because that conveniently > advances our pointer. But it also gets rid of the sha1 name. Arguably > it's a little funny to use "object_id" here for something that isn't > actually naming an object, but it's unlikely to be a problem (and is > contained in a single function). Not that it matters, but I think the argument would be that having "oid" in the function call probably isn't ideal, but it's closer to the ideal than having "sha1" in the same call (which isn't always the case). Likewise about advancing the pointer, since everything is pass-by-value, modifying the stack local copy of path doesn't matter to callers of is_rr_cache_dirname(). So I think that this change is an improvement over the status-quo here. Thanks, Taylor
