RE: Git Commit Signature Encoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philippe,

thanks for getting back to me so quickly! And sorry for not providing all the details right away.

I'm using Git 2.30.0.windows.1 (I believe that's the latest), gpg 2.2.27 (installed via gpg4win 3.1.15), and PowerShell 7.1.1. You might have seen my second email to the list in which I described that setting the OutputEncoding in PowerShell to UTF-8 fixed at least the display of the é (and probably all other umlauts and special printable characters). The signature output from git show --show-signatur is still printing the ^M carriage return character at the end of each line:

commit 69022a47744fcb3801572ac5d14295bcab274295 (HEAD -> master)
gpg: Signature made 26.01.2021 17:55:36 W. Europe Standard Time^M
gpg:                using RSA key 3848D5B2A3D45419D7F564F97802B995CDB4A2EF^M
gpg: Good signature from "René Schumacher <rene.schumacher@xxxxxxxxxxxxx>" [ultimate]^M
gpg:                 aka "René Schumacher <reneschu@xxxxxxxxxxxxx>" [ultimate]^M
Author: René Schumacher <reneschu@xxxxxxxxxxxxx>
Date:   Tue Jan 26 17:55:36 2021 +0100

    another commit with signature

diff --git a/file1.txt b/file1.txt
index a7f8d9e..6ddadea 100644
--- a/file1.txt
+++ b/file1.txt
@@ -1 +1,2 @@
 bla
+blub

Since git verify-commit does not have those carriage return characters, I'm still wondering where they might come from.

Cheers,
René

-----Original Message-----
From: Philippe Blain <levraiphilippeblain@xxxxxxxxx> 
Sent: Dienstag, 26. Januar 2021 20:12
To: Rene Schumacher <Rene.Schumacher@xxxxxxxxxxxxx>; git@xxxxxxxxxxxxxxx
Subject: Re: Git Commit Signature Encoding

Hi René,

Le 2021-01-26 à 09:30, Rene Schumacher a écrit :
> Hi all,
> 
> I'm trying to fix an encoding (?) issue when viewing gpg signatures for commits in PowerShell Core on Windows. Apparently, git changes the output from gpg depending on the command used. Here's what I see:
> 
> git show --show-signature
> This command shows strange line endings and is unable to properly display the é in my name:
> 
> commit d7a43da0bd3bc7e31dd46afb8ccd78735ba43a36 (HEAD -> master)
> gpg: Signature made 26.01.2021 15:28:26 W. Europe Standard Time^M
> gpg:                using RSA key 3848D5B2A3D45419D7F564F97802B995CDB4A2EF^M
> gpg: Good signature from "Ren<82> Schumacher <rene.schumacher@xxxxxxxxxxxxx>" [ultimate]^M
> gpg:                 aka "Ren<82> Schumacher <reneschu@xxxxxxxxxxxxx>" [ultimate]^M
> Author: René Schumacher <reneschu@xxxxxxxxxxxxx>
> Date:   Tue Jan 26 15:28:26 2021 +0100
> 
>      Commit with signature
> 
> diff --git a/file1.txt b/file1.txt
> new file mode 100644
> index 0000000..a7f8d9e
> --- /dev/null
> +++ b/file1.txt
> @@ -0,0 +1 @@
> +bla
> 
> 
> git verify-commit
> This command does not show the line endings but still fails to properly show the é:
> 
> gpg: Signature made 26.01.2021 15:28:26 W. Europe Standard Time
> gpg:                using RSA key 3848D5B2A3D45419D7F564F97802B995CDB4A2EF
> gpg: Good signature from "Ren82 Schumacher <rene.schumacher@xxxxxxxxxxxxx>" [ultimate]
> gpg:                 aka "Ren82 Schumacher <reneschu@xxxxxxxxxxxxx>" [ultimate]
> 
> 
> git verify-commit --raw
> This command does properly show the é in my name so I guess that gpg output is correct and there's something happening while git parses the gpg output:
> 
> [GNUPG:] NEWSIG
> [GNUPG:] KEY_CONSIDERED 3848D5B2A3D45419D7F564F97802B995CDB4A2EF 0 
> [GNUPG:] SIG_ID jBtyyA8QIDL0tD5fneVqJo7oU/8 2021-01-26 1611671306 
> [GNUPG:] KEY_CONSIDERED 3848D5B2A3D45419D7F564F97802B995CDB4A2EF 0 
> [GNUPG:] GOODSIG 7802B995CDB4A2EF René Schumacher 
> <rene.schumacher@xxxxxxxxxxxxx> [GNUPG:] VALIDSIG 
> 3848D5B2A3D45419D7F564F97802B995CDB4A2EF 2021-01-26 1611671306 0 4 0 1 
> 8 00 3848D5B2A3D45419D7F564F97802B995CDB4A2EF
> [GNUPG:] KEY_CONSIDERED 3848D5B2A3D45419D7F564F97802B995CDB4A2EF 0 
> [GNUPG:] TRUST_ULTIMATE 0 pgp [GNUPG:] VERIFICATION_COMPLIANCE_MODE 23
> 
> 
> I already set the environment variable LC_ALL to C.UTF-8, which fixed the commit message output (see first screenshot) but unfortunately not the signature output. Any idea what might be causing this and how to fix it (if possible)?
> 

What Git and GPG versions are you running ? And what Powershell version (I don't think that matters but still, a complete environment description usually goes a long way).

Can you come up with a reproducible example ? (Complete steps starting with 'git init' and 'gpg --gen-key')

Cheers,

Philippe.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux