Note: this is purely style, and minor, but I'll ask... On Tue, Jan 26, 2021 at 8:08 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > static int write_graph_chunk_fanout(struct hashfile *f, > - struct write_commit_graph_context *ctx) > + void *data) > { > + struct write_commit_graph_context *ctx = > + (struct write_commit_graph_context *)data; Why bother with the cast on the last line here? In C, conversion from `void *` to `struct whatever *` is fine. (the change itself looks fine, btw) Chris