On Tue, Jan 26, 2021 at 04:01:13PM +0000, Derrick Stolee via GitGitGadget wrote:
> This change only renames "struct pack_info" to "struct
> write_midx_context" and the names of instances from "packs" to "ctx". In
> future changes, we will expand the data inside "struct
> write_midx_context" and align our chunk-writing method with the
> chunk-format API.
Thanks for saying that; that makes clear what is (and isn't) going on
here.
> @@ -463,37 +463,37 @@ struct pack_list {
> static void add_pack_to_midx(const char *full_path, size_t full_path_len,
> const char *file_name, void *data)
> {
> - struct pack_list *packs = (struct pack_list *)data;
> + struct write_midx_context *ctx = (struct write_midx_context *)data;
Same comments as earlier about the unnecessary cast on the right-hand
side of this (and the below) assignment.
Otherwise this patch looks obviously fine to me.
Thanks,
Taylor
