Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Tue, Jan 26 2021, Jacob Vosmaer wrote: > >> This fixes a bug that occurs when you combine partial clone and >> uploadpack.packobjectshook. You can reproduce it as follows: > > Let's: > > * Refer to the commit we're fixing a bug in, i.e. Junio's mention of > 10ac85c7 (upload-pack: add object filtering for partial clone, > 2017-12-08) upthread. > > * See also "imperative-mood" in SubmittingPatches. I.e. say "Fix a bug > in ..." not "This fixes ... can be reproduced as" > > * uploadpack.packObjectsHook not uploadpack.packobjectshook except in C > code. > > ... [jc: all the helpful hints snipped] ... > > Thanks for hacking this up! Hopefully the above is helpful and not too > nitpicky. Mainly wanted to help you get future patches through more > easily... Yeah, thanks, both, for aiming higher ;-) I have to admit that I did find the log message a bit lacking, and that was why I had to dig bit to find out how the historical issue happened myself in the first place, and I tend to agree that it feels a bit of waste for that work to end up buried in the list archive without getting reflected in the proposed log message.
