Alex Riesen <raa.lkml@xxxxxxxxx> writes:
> For reason unknown a package in ActiveState Perl 5.8.7 must implement
> READLINE method differently for scalar and array context. The code
> tested to work for more sane and recent version of perl (5.8.8 shipped
> with Ubuntu), so maybe it was always a requirement.
Well spotted.
Unfortunately, the manual perltie.pod is very sketchy on this
issue, and only says:
This method will be called when the handle is read from via <HANDLE>.
The method should return undef when there is no more data.
The default implementation in Tie::StdHandle (Tie/Handle.pm)
does agree with you by doing this:
sub READLINE { my $fh = $_[0]; <$fh> }
So I am fairly confident that your patch is the right fix.
Interestingly, CPAN::Tarzip::READLINE (CPAN.pm) gets it wrong ;-)
and caters only to calls in scalar context if I am reading the
code correctly.
Thanks. Will apply.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
