On Fri, Jan 22, 2021 at 5:04 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > This is based on ds/cache-tree-basics. > > Here are a few more cleanups that are vaguely related to the index. I > discovered these while preparing my sparse-index RFC that I intend to send > early next week. > > The biggest patch is the final one, which creates a test script for > comparing sparse-checkouts to full checkouts. There are some commands that > do not behave similarly. This script will be the backbone of my testing > strategy for the sparse-index by adding a new mode to compare > sparse-checkouts with the two index types (full and sparse). > > > UPDATES IN V2 > ============= > > * Fixed duplicated test in t1092. > > * Changed the implementation of 'test_region' after I discovered the > negation doesn't work correctly. (I updated the test to use what was in > t0500-progress-display.sh at the last minute before v1, but that > implementation was wrong.) The use of it in t0500-progress-display.sh was > incorrect, as well. > > * Updated commit messages to be more informative and have fewer typos. > > * I dropped the patch that placed the sparse-checkout patterns in struct > index_state. I'll re-introduce that in time for the actual use of the > member. You've addressed all my feedback from v1, but it looks like you missed the pos + 1 changes highlighted by Chris in his review of patch 3. Oversight?
